SEPURI-SAI-KRISHNA commented on PR #71646:
URL: https://github.com/apache/airflow/pull/71646#issuecomment-5323219519
Thanks @ramitkataria, done in both places.
The operator test now asserts the whole serialized trigger payload instead
of picking out one field:
```python
assert deferred.value.trigger.serialize()[1] == {
"db_cluster_id": CLUSTER_ID,
"aws_conn_id": "aws_default",
"region_name": REGION_NAME,
"verify": VERIFY,
"botocore_config": BOTOCORE_CONFIG,
"waiter_delay": WAITER_DELAY,
"waiter_max_attempts": WAITER_MAX_ATTEMPTS,
}
```
Exact-dict equality rather than a set of individual asserts, so an argument
going missing on the way to the triggerer fails the suite, which is exactly the
failure mode this PR is about. The same assertion is now in the trigger test
across all three trigger classes.
One nuance the wider assertions surfaced, worth recording: of the three
arguments the operators now forward, only `region_name` was actually being
lost. `verify` and `botocore_config` are not named parameters on the Neptune
trigger `__init__`s, so they already reached `AwsBaseWaiterTrigger` through
`**kwargs`. `region_name` *is* named, so the subclass bound it and never passed
it up. The widened assertions still fail without the source change, and they
now also pin down the two that were only working by accident.
Verified locally: 31 passed with the change, and exactly the 5 new
parametrizations fail with it reverted (26 pre-existing tests unaffected either
way).
---
Drafted-by: Claude Code (Opus 5); reviewed by @SEPURI-SAI-KRISHNA before
posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
