hkc-8010 commented on PR #70370: URL: https://github.com/apache/airflow/pull/70370#issuecomment-5385387768
@amoghrajesh Agreed the counterpart is the real fix, and #71802 is already adding `SerializedVariableInterval` for it. I did not want this bugfix to depend on that landing, so here the SDK type is confined to one function, `resolve_deadline_alert_interval()` in `serialization/decoders.py`, which both DagRun creation and the deadline recalculation now call. That is the only `isinstance` against the SDK dataclass left in this path, so when #71802 lands it changes in one place and no call site moves. The duplication you flagged is gone too. `taskinstance.py` has no SDK import, and `definitions/dag.py` dropped its `VariableInterval` import, so the hook tightened `generated/known_sdk_imports_in_core.txt` from 2 to 1 for that file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
