ferruzzi commented on PR #70714: URL: https://github.com/apache/airflow/pull/70714#issuecomment-5417231318
Heads up on sequencing: this PR now overlaps two others in `_recalculate_dagrun_queued_at_deadlines`. - #70370 (opened 24 July) is the targeted fix for the JSON-interval `TypeError` on that function. It is milestoned **3.3.2** and carries `backport-to-v3-3-test`. - #71850 (opened 19 August) persists the evaluation timing so custom queued-anchored references get re-anchored on clear. It also conflicts with this PR across sevreral files. This PR fixes the same `TypeError` incidentally, and I want to be explicit that **that does not make #70370 redundant**. This is a refactor with a `significant.rst` newsfragment and a deprecation, so it is not backport material; #70370 is the only route the fix has to 3.3.x, where it currently affects every queued-at deadline. Please do not let this PR be used as a reason to close that one. The cheapest merge order looks like it will be to merge #70370 first, then rebase here. #70370 adds `decode_deadline_alert_model()` and `resolve_deadline_alert_interval()` to `serialization/decoders.py`, which is exactly what this PR hand-rolls at `taskinstance.py:255-260`. Rebasing onto it lets you delete those lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
