ferruzzi commented on PR #70714: URL: https://github.com/apache/airflow/pull/70714#issuecomment-5417478774
Adding a fourth PR to the picture since it breaks something here concretely. #71802 adds a core-side `SerializedVariableInterval`, makes `decode_deadline_alert` return that instead of `VariableInterval`, and deletes `resolve()` from the SDK entirely. That will break `test_clear_task_instances_recalculates_variable_interval_deadline`, which patches `airflow.sdk.definitions.deadline.Variable.get`. Worth knowing now rather than after a rebase. Also worth noting, #71850's diff still has `required_kwargs: set[str] = set()` on `SerializedBaseDeadlineReference`, which this PR removes, and it adds an `evaluation_timing` class attribute immediately below it. So be careful when rebasing, whichever lands first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
