rjgoyln commented on PR #71850: URL: https://github.com/apache/airflow/pull/71850#issuecomment-5421425936
> Cross-linking, since this overlaps two other open PRs on the same code and I do not think the three authors are aware of each other. > > #70714 (opened 30 July) changes deadline references to receive the in-memory `DagRun` instead of `dag_id` and `run_id`, and deprecates `required_kwargs`. It overlaps this PR across a bunch of files. Worth a look before you rebase, particularly `_evaluate_with`'s signature, which it narrows from `**kwargs` to a keyword-only `dagrun`. > > On the interval workaround: once #70370 lands, storing numeric intervals in the tests to stay clear of the JSON bug is no longer necessary, and storing `serialize(interval)` instead would then hit the production write path. That legacy-float shortcut is what hid the `TypeError` in the existing test in the first place, so it is worth removing rather than inheriting once the fix is in. Thanks for the cross-links! I’d only accounted for #70370. For #70714, I’ll keep the `evaluation_timing` deletions when rebasing and follow the keyword-only `dagrun` signature. For the interval tests, agreed — I’ll switch them to `serialize(interval)` once #70370 lands and remove the note from the description. #71802 noted as well. It should be a textual conflict in the interval handling rather than a behavioral one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
