dimberman commented on a change in pull request #7085: [AIRFLOW-6334] Use 
classes instead list of string in executors
URL: https://github.com/apache/airflow/pull/7085#discussion_r364453845
 
 

 ##########
 File path: airflow/executors/base_executor.py
 ##########
 @@ -232,14 +255,14 @@ def get_event_buffer(self, dag_ids=None) -> 
Dict[TaskInstanceKeyType, Optional[s
 
     def execute_async(self,
                       key: TaskInstanceKeyType,
-                      command: CommandType,
+                      deferred_run: LocalTaskJobDeferredRun,
                       queue: Optional[str] = None,
 
 Review comment:
   I agree with @dazza-codes here. At first glance, the name 
LocalTaskJobDeferredRun has a LOT going on it and is kind of hard to understand 
for people not well acquainted with the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to