mik-laj commented on issue #7085: [AIRFLOW-6334] Use classes instead list of 
string in executors
URL: https://github.com/apache/airflow/pull/7085#issuecomment-572484694
 
 
   > So... question... If we're going to go through all this trouble in the 
first place, why not just do away with the whole command-line based workflow 
overall? We're taking so much time to find cleaner command generators when I 
think we should consider new designs that are easier to debug.
   
   Because of a few reasons:
   * Some executors will still require CLI, e.g. KubernetesExecutor.
   * Backward compatibility. Do not want to cause more incompatibility than 
necessary. Do not want to cause more incompatibility than necessary.  The 
update path is now relatively short. See UPDATING.md
   * I want to limit the scope of this PR only to necessary changes. In 
particular, I wanted to focus on BaseExecutor. Other executors can then be 
optimized to take advantage of the new possibilities that this PR will give, 
but this must be analyzed for each executor separately because it can create 
side effects.
   
   In the future I would like to completely get rid of the `as_command` method 
if no execuctor will use it anymore, but this probably won't happen because 
KubernetesExecutor will still require it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to