subhramit commented on PR #71976: URL: https://github.com/apache/airflow/pull/71976#issuecomment-5445788523
@eladkal I noticed a separate dependency issue while working on this. `InfluxDB3Hook.query()` and `query_async()` import `pandas` at runtime, but the provider doesn't declare a it as an extra or convert missing-`pandas` imports into an optional-feature error, which means users would hit a `ModuleNotFoundError` when using those query paths if they don't have `pandas` installed. I took the opportunity and covered that in https://github.com/apache/airflow/pull/71976/commits/1b7294bd9df65b334826a92e9e8df1d81facf7c3 by adding the `pandas` extra and raising `AirflowOptionalProviderFeatureException` from those paths when `pandas` isn’t installed, like how it’s done in https://github.com/apache/airflow/blob/ee15456649aa6dfed1dd5385888d81d672bc21ad/providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py#L1083-L1087 and also in [`transfers/sql_to_s3.py`](https://github.com/apache/airflow/blob/ee15456649aa6dfed1dd5385888d81d672bc21ad/providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py#L184-L186). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
