subhramit commented on code in PR #71976:
URL: https://github.com/apache/airflow/pull/71976#discussion_r3889457458
##########
providers/influxdb/src/airflow/providers/influxdb/operators/influxdb3.py:
##########
@@ -23,13 +23,21 @@
from collections.abc import Sequence
from typing import TYPE_CHECKING, Any
-from airflow.providers.common.compat.sdk import BaseOperator
+from airflow.providers.common.compat.sdk import BaseOperator, conf
from airflow.providers.influxdb.hooks.influxdb3 import InfluxDB3Hook
+from airflow.providers.influxdb.triggers.influxdb3 import InfluxDB3QueryTrigger
if TYPE_CHECKING:
+ import pandas as pd
+
from airflow.sdk.definitions.context import Context
+def _convert_dataframe_to_records(dataframe: pd.DataFrame) -> list[dict[str,
Any]]:
Review Comment:
Since python allows it, I relaxed module encapsulation a bit, but only
inside the provider's internal implementation to not create a new file and
still reuse it in
https://github.com/apache/airflow/pull/71976/commits/e6a177c1105e7065829dcad2a8a3a671d5b5cf51.
See if that is alright or we should indeed go with a new file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
