subhramit commented on code in PR #71976:
URL: https://github.com/apache/airflow/pull/71976#discussion_r3889500725
##########
providers/influxdb/tests/unit/influxdb/hooks/test_influxdb3.py:
##########
@@ -85,6 +85,46 @@ def test_query(self):
assert isinstance(result, pd.DataFrame)
assert len(result) == 2
+ @pytest.mark.asyncio
+ async def test_query_async(self):
+ """Test async query with InfluxDB 3.x."""
+ pd = pytest.importorskip("pandas")
+
+ self.influxdb3_hook.client = mock.Mock()
Review Comment:
Makes sense, used shape-constrained mocks.
I did have a look at pushing the seam lower but for `query()`/
`query_async()`
that would mean mocking upsteam client internals rather than our hook
contract. IMO point of these hook tests are to validate our interaction with
`InfluxDBClient3` and the DataFrame/type handling around it, so I kept them at
the client boundary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
