zohaibfast99 commented on issue #72144: URL: https://github.com/apache/airflow/issues/72144#issuecomment-5551022501
I'd like to take the two Shape A call sites (aws/operators/glue.py:361 and aws/sensors/glue.py:99) GlueJobCompleteTrigger already accepts `egion_name, verify and botocore_config and already forwards all three in its hook(), so those two are a call-site-only fix that works either side of #72171. PR coming shortly. One thing I noticed while tracing it: the ECS rows under "Shape B (operator-side fix only)" may need a second look. ClusterActiveTrigger.hook() and ClusterInactiveTrigger.hook() return `EcsHook(aws_conn_id=self.aws_conn_id, region_name=self.region_name), so although **kwargs reaches AwsBaseWaiterTrigger and the parameters would serialize, the hook is still built without them. Those two look like they need the hook() widened as well, unless #72171 lands first! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
