SEPURI-SAI-KRISHNA commented on issue #72144:
URL: https://github.com/apache/airflow/issues/72144#issuecomment-5552235780
On the ECS rows, you're right, and the "operator-side fix only" label on
them is wrong.
Both triggers do take `**kwargs` and forward to `AwsBaseWaiterTrigger`, so
`verify` and `botocore_config` serialize and round-trip fine. But each one then
overrides `hook()`:
```python
# triggers/ecs.py on main, lines 47-48 and 87-88
def hook(self) -> AwsGenericHook:
return EcsHook(aws_conn_id=self.aws_conn_id,
region_name=self.region_name)
```
So the parameters arrive on the trigger and are dropped when the hook is
built. Passing them at the call site alone changes nothing observable. Those
two rows belong under Shape C, not Shape B, I grouped the table by whether the
trigger's `__init__` accepts the parameters, when the question that actually
matters is whether `hook()` consumes them. I'll correct the table.
Your caveat is right too: #72171 already covers both. It sets
`aws_hook_class = EcsHook` on `ClusterActiveTrigger` and
`ClusterInactiveTrigger` and deletes the `hook()` override, so the base class
builds the hook from all three serialized parameters.
---
On glue, a heads-up so a reviewer doesn't meet it cold: #72557 and #72171
overlap on the same lines. #72171 touches `operators/glue.py` and
`sensors/glue.py` for the two Shape A sites you picked up, and also widens
`triggers/glue.py`.
Worth knowing that the two Shape A sites aren't all of glue.
`GlueDataQualityRuleSetEvaluationRunSensor` and
`GlueDataQualityRuleRecommendationRunSensor` also defer, and their triggers are
Shape C, closed `__init__` signatures that never accept the three parameters,
so those two can't be fixed at the call site and aren't covered by #72557.
Your PR is smaller and self-contained, so I'm happy for it to land first;
I'll rebase #72171 and drop the four overlapping lines. Nothing needed from
you, just flagging the overlap.
Separately, and not aimed at anyone in particular: I've added a status block
at the top of the issue. Between #72171, #72449 and #72472 the sites in those
tables are now all spoken for, so if you are reading this and thinking of
picking up a service, please comment here first. I would much rather make room
for you than have you write something that ends up closed as a duplicate.
---
Drafted-by: Claude Code (Opus 5); reviewed by @SEPURI-SAI-KRISHNA before
posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
