Eason09053360 opened a new pull request, #72633:
URL: https://github.com/apache/airflow/pull/72633

   The StatsD Deployment only rendered its `checksum/statsd-config` pod 
annotation when `statsd.extraMappings` or `statsd.podAnnotations` was set. The 
StatsD ConfigMap, however, also changes with `statsd.overrideMappings` and 
`statsd.cache.ttl` — so changing either of those updated the ConfigMap without 
rolling the pod, and `statsd-exporter` (which reads `mappings.yml` only at 
startup) silently kept serving the old mappings.
   
   The annotation is now rendered unconditionally, matching the 
`otel-collector` Deployment, so any value that affects the ConfigMap triggers a 
rollout without having to be enumerated in the template.
   
   The checksum is also narrowed to the ConfigMap's `.data` rather than the 
whole rendered document. The full document includes the `chart: 
<name>-<version>` label, so hashing it would restart StatsD on every chart 
version bump even with unchanged values — something a default install never did 
before. With the `.data`-only hash, only real mapping/cache changes roll the 
pod; metadata-only changes (chart version, `configMapAnnotations`, global 
`labels`) do not. This is the one place the chart hashes `.data` instead of the 
full document; the other components' images change with the chart version 
anyway, while the StatsD image is pinned independently.
   
   **Upgrade note:** existing StatsD pods restart once on upgrade to this chart 
version (the annotation is new for default installs, and its value changes for 
`extraMappings` users). After that, chart version bumps no longer restart 
StatsD.
   
   Verified with `helm template`:
   
   | values | before | after |
   |---|---|---|
   | `overrideMappings` changed | no rollout | rollout |
   | `cache.ttl` changed | no rollout | rollout |
   | `extraMappings` changed | rollout | rollout |
   | chart version bump only, with `extraMappings` | rollout | no rollout |
   | chart version bump only, default install | no rollout | no rollout |
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5.1)
   
   Generated-by: Claude Code (Fable 5.1) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to