Eason09053360 commented on code in PR #72633:
URL: https://github.com/apache/airflow/pull/72633#discussion_r3974687726
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -64,13 +64,11 @@ spec:
{{- if or .Values.labels .Values.statsd.labels }}
{{- mustMerge .Values.statsd.labels .Values.labels | toYaml |
nindent 8 }}
{{- end }}
- {{- if or .Values.statsd.extraMappings .Values.statsd.podAnnotations }}
annotations:
- checksum/statsd-config: {{ include (print $.Template.BasePath
"/configmaps/statsd-configmap.yaml") . | sha256sum }}
- {{- if .Values.statsd.podAnnotations }}
- {{- tpl (toYaml .Values.statsd.podAnnotations) . | nindent 8 }}
+ checksum/statsd-config: {{ (include (print $.Template.BasePath
"/configmaps/statsd-configmap.yaml") . | fromYaml).data | toYaml | sha256sum }}
Review Comment:
Fair point, it can keeps StatsD consistent with how every other component
hashes its config.
Reverted to the full-document checksum and dropped the test case that
asserted metadata-only changes do not roll the pod. And also PR description
updated to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
