realtimetodie commented on PR #72458: URL: https://github.com/apache/airflow/pull/72458#issuecomment-5575964041
@xBis7 I rebased with the main branch and had to revert the shared `expand_dag_tags` usage from `stats.py` again because, as of #72364, build_dag_metric_tags contains StatsD-specific normalization logic. I hate how StatsD is polluting the observability stack. At this point the metrics behavior is no longer equivalent to the generic DAG tag expansion used for spans, so keeping them shared would change the current metrics behavior. I am keeping expand_dag_tags only for spans and leaving build_dag_metric_tags independent. As I mentinoned before, in an upcoming pull request, I would like to change how DAG tags are represented in OpenTelemetry. Expanding every single tag into attributes is needed for StatsD-style metrics, but OpenTelemetry supports string-array attributes. This means all DAG tags in spans and metrics could be exported under a single attribute instead for OpenTelemetry, for example: ``` airflow.dag.tags = ["finance", "production", "team:data"] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
