rjgoyln commented on PR #72376: URL: https://github.com/apache/airflow/pull/72376#issuecomment-5594163515
Thanks for the thorough review! I traced the Triggerer lifecycle as well and agree with your points. I’ve: * Fixed the docstring typo. * Removed the ineffective `log.exception` assertions. * Updated the PR description to clarify that dependents already failed before this change; raising now additionally preserves the traceback. * Kept the constructor validation as-is, since the `ValueError` handling in `create_triggers()` is a broader Triggerer concern and not specific to this PR. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
