FrankYang0529 commented on code in PR #72579:
URL: https://github.com/apache/airflow/pull/72579#discussion_r3978187780


##########
.pre-commit-config.yaml:
##########
@@ -1351,6 +1351,12 @@ repos:
         language: python
         pass_filenames: false
         files: 
^airflow-core/src/airflow/utils/[^/]+$|^scripts/ci/prek/known_airflow_core_utils_modules\.txt$|^scripts/ci/prek/check_no_new_airflow_core_utils_modules\.py$
+      - id: check-mapped-column-nullable-annotations
+        name: Check that nullable mapped_column attributes are annotated 
Mapped[X | None]
+        entry: ./scripts/ci/prek/check_mapped_column_nullable_annotations.py
+        language: python
+        pass_filenames: true
+        files: 
^(airflow-core|providers)/.*\.py$|^scripts/ci/prek/check_mapped_column_nullable_annotations\.py$

Review Comment:
   Thanks for the review. Changed it to
   
   ```
             ^airflow-core/src/airflow/(models|jobs)/.*\.py$|
             ^providers/edge3/src/airflow/providers/edge3/models/.*\.py$|
             
^providers/fab/src/airflow/providers/fab/auth_manager/models/.*\.py$|
             ^scripts/ci/prek/check_mapped_column_nullable_annotations\.py$
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to