FrankYang0529 commented on PR #72579: URL: https://github.com/apache/airflow/pull/72579#issuecomment-5617307052
> Just found out there's a case in `airflow-core/src/airflow/models/xcom.py::XComModel` dag_result. Is it something missed? IIUC, we don't miss it. It was introduced by this migration (new column with nullable=True). https://github.com/apache/airflow/blob/b13414865e100cb181634505f8330d9b5f3baeb2/airflow-core/src/airflow/migrations/versions/0110_3_3_0_xcom_dag_result.py#L44 For old rows in that table, they don't backfill with default value `False`. Only new row does. I think we should keep it as `Mapped[bool | None]`. https://github.com/apache/airflow/blob/b13414865e100cb181634505f8330d9b5f3baeb2/airflow-core/src/airflow/models/xcom.py#L70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
