ColtenOuO commented on code in PR #71734:
URL: https://github.com/apache/airflow/pull/71734#discussion_r3989043713
##########
providers/common/ai/tests/unit/common/ai/operators/test_llm_file_analysis.py:
##########
@@ -346,3 +346,35 @@ def test_execute_with_approval_timeout(
op.execute(context=_make_context())
assert exc_info.value.timeout == timeout
+
+
[email protected](
Review Comment:
Thanks, removed the skip and renamed the class. It's now parametrized over
`require_approval` so both paths are covered.
The same `AIRFLOW_V_3_1_PLUS` skip is on the prompt-guard tests in
`test_llm.py`, `test_llm_sql.py`, and `test_agent.py`, and those also raise
before any HITL code runs. Should I fix them in a separate follow-up PR?
(because the orgional test implementation is base on these files, so I
notice this point ...or am I misunderstanding something?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
