ColtenOuO commented on code in PR #71734:
URL: https://github.com/apache/airflow/pull/71734#discussion_r3989007451
##########
providers/common/ai/src/airflow/providers/common/ai/operators/llm_file_analysis.py:
##########
@@ -105,6 +105,9 @@ def __init__(
self.sample_rows = sample_rows
def execute(self, context: Context) -> Any:
+ if self.require_approval:
Review Comment:
Yeah... I had a slight misunderstanding of the codebase earlier. My
apologies, I should have run it locally to double-check first.
I have updated the PR title and description. Also, making the check
unconditional rather than tied to `require_approval` makes total sense to me,
handling it directly inside with a clearer error message provides a much better
experience for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
