abhinav-phi commented on code in PR #73109:
URL: https://github.com/apache/airflow/pull/73109#discussion_r4007690053
##########
providers/amazon/tests/unit/amazon/aws/operators/test_eks.py:
##########
@@ -760,6 +760,11 @@ def test_eks_delete_cluster_operator_with_deferrable(self):
with pytest.raises(TaskDeferred):
self.delete_cluster_operator.execute({})
+ def test_execute_complete_when_trigger_yields_deleted(self, caplog):
+ # EksDeleteClusterTrigger yields {"status": "deleted"}, not "success".
+ self.delete_cluster_operator.execute_complete(context={},
event={"status": "deleted"})
+ assert "Cluster deleted successfully." in caplog.messages
Review Comment:
Good catch — switched to the structured-membership assertion: `assert
"Cluster deleted successfully." in caplog` (exact match on the captured `event`
field, since `caplog` is backed by the StructlogCapture fixture now). All 9
tests in the class pass locally; amended into the single commit and rebased
onto main. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
