Vamsi-klu commented on code in PR #73109:
URL: https://github.com/apache/airflow/pull/73109#discussion_r4002488339
##########
providers/amazon/tests/unit/amazon/aws/operators/test_eks.py:
##########
@@ -760,6 +760,11 @@ def test_eks_delete_cluster_operator_with_deferrable(self):
with pytest.raises(TaskDeferred):
self.delete_cluster_operator.execute({})
+ def test_execute_complete_when_trigger_yields_deleted(self, caplog):
+ # EksDeleteClusterTrigger yields {"status": "deleted"}, not "success".
+ self.delete_cluster_operator.execute_complete(context={},
event={"status": "deleted"})
+ assert "Cluster deleted successfully." in caplog.messages
Review Comment:
This asserts through caplog.messages, which is the raw-log API the project
is retiring. Use a structured caplog membership assertion instead. The
production fix itself is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
