zozo123 commented on code in PR #71672:
URL: https://github.com/apache/airflow/pull/71672#discussion_r4006183386


##########
providers/common/ai/docs/toolsets.rst:
##########
@@ -793,6 +793,60 @@ Constructor parameters:
   guarantee this backend cannot make. Set ``"deny-all"`` after running
   ``sbx policy init deny-all``, or ``"allow-all"`` to state that egress is 
open.
 
+Islo backend
+^^^^^^^^^^^^
+
+:class:`~airflow.providers.common.ai.sandbox.IsloSandboxBackend` runs each

Review Comment:
   Here it is, against a real Islo microVM:
   
   ![SandboxToolset on an islo.dev 
microVM](https://raw.githubusercontent.com/zozo123/airflow/demo/islo-sandbox/islo-sandbox.gif)
   
   A deterministic pydantic-ai `FunctionModel` drives it, so the run is 
reproducible and needs no LLM. Each of the four tools is called in turn, and 
the steps double as evidence for the findings in your other review: the 
backgrounded process returns immediately, the agent's files keep normal 
permissions, deny-all egress holds, and a nonzero exit comes back as a 
retryable error. Source and recording are on [this 
branch](https://github.com/zozo123/airflow/tree/demo/islo-sandbox) — 
deliberately not part of the PR.
   
   The shipped system test (`example_sandbox_toolset_islo.py`) passes against 
the same live backend:
   
   ```console
   $ ISLO_API_KEY=... pytest --system 
providers/common/ai/tests/system/common/ai/example_sandbox_toolset_islo.py
   
providers/common/ai/tests/system/common/ai/example_sandbox_toolset_islo.py::test_run
 PASSED [100%]
   1 passed in 11.25s
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to