Vamsi-klu commented on code in PR #73105:
URL: https://github.com/apache/airflow/pull/73105#discussion_r4002488212
##########
airflow-core/src/airflow/cli/cli_config.py:
##########
@@ -294,7 +294,7 @@ def string_lower_type(val):
# list_jobs
ARG_DAG_ID_OPT = Arg(("-d", "--dag-id"), help="The id of the dag")
-ARG_LIMIT = Arg(("--limit",), help="Return a limited number of records")
+ARG_LIMIT = Arg(("--limit",), type=positive_int(allow_zero=False),
help="Return a limited number of records")
Review Comment:
allow_zero=False rejects --limit 0 and --limit -1. Before this those were
strings and could become LIMIT 0 or a driver-specific negative limit. No
help-text change, no test. ARG_JOB_LIMIT documents that 0 disables the cap.
Different flag, same --limit spelling.
The new test only checks "abc" and code == 2. Pin the argparse message, and
add --limit 0 / --limit -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
