cruseakshay commented on code in PR #64941: URL: https://github.com/apache/airflow/pull/64941#discussion_r4016145709
########## providers/amazon/src/airflow/providers/amazon/aws/datafusion/object_storage.py: ########## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datafusion.object_store import AmazonS3 + +from airflow.providers.amazon.aws.hooks.base_aws import AwsGenericHook +from airflow.providers.common.compat.sdk import BaseHook +from airflow.providers.common.sql.config import ConnectionConfig, StorageType +from airflow.providers.common.sql.datafusion.base import ObjectStorageProvider +from airflow.providers.common.sql.datafusion.exceptions import ObjectStoreCreationException + + +class S3ObjectStorageProvider(ObjectStorageProvider): + """S3 Object Storage Provider using DataFusion's AmazonS3.""" + + @property + def get_storage_type(self) -> StorageType: + """Return the storage type.""" + return StorageType.S3 + + def create_object_store(self, path: str, connection_config: ConnectionConfig | None = None): + """Create an S3 object store using DataFusion's AmazonS3.""" + if connection_config is None: + raise ValueError(f"connection_config must be provided for {self.get_storage_type}") + + try: + conn = BaseHook.get_connection(connection_config.conn_id) + aws_hook: AwsGenericHook = AwsGenericHook(aws_conn_id=conn.conn_id, client_type="s3") + creds = aws_hook.get_credentials() + + credentials = { + "access_key_id": conn.login or creds.access_key, + "secret_access_key": conn.password or creds.secret_key, + "session_token": creds.token if creds.token else None, + } + credentials = {k: v for k, v in credentials.items() if v is not None} + extra_config = {k: conn.extra_dejson[k] for k in ["region", "endpoint"] if k in conn.extra_dejson} Review Comment: Taking the first option here: the existing contract is preserved, and the hook redesign is left to a separate PR, so this stays the same behaviour. Added tests covering explicit credentials (asserting the hook is never consulted), extra_config precedence, and the same explicit-credentials path through the deprecated import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
