ramitkataria commented on code in PR #64941:
URL: https://github.com/apache/airflow/pull/64941#discussion_r4044909201
##########
providers/common/sql/pyproject.toml:
##########
@@ -100,6 +97,9 @@ dependencies = [
"apache.iceberg" = [
"apache-airflow-providers-apache-iceberg"
]
+"amazon" = [
+ "apache-airflow-providers-amazon>=9.36.0"
Review Comment:
Amazon 9.36.0 has since been released without this change, so should this be
`>=9.37.0` with the matching amazon version bump in this PR?
##########
providers/amazon/pyproject.toml:
##########
Review Comment:
We might want to add `apache-airflow-providers-amazon[datafusion]` to the
dev group, like `[aiobotocore]` and `[sqlalchemy]` above? Otherwise, I think
running `uv run --project providers/amazon pytest
tests/unit/amazon/aws/datafusion` would fail with module-not-found error. I
would passin Breeze regardless because common-sql's dev group would pull it in
##########
providers/amazon/pyproject.toml:
##########
Review Comment:
Does the `datafusion` extra need
`apache-airflow-providers-common-sql>=1.33.0`? `object_storage.py` imports
`common.sql.config` and `datafusion.base` / `datafusion.exceptions`
unconditionally, and it looks like those only exist from 1.33.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
