VladaZakharova commented on code in PR #71775:
URL: https://github.com/apache/airflow/pull/71775#discussion_r4082481713
##########
providers/google/src/airflow/providers/google/cloud/transfers/bigquery_to_sql.py:
##########
@@ -93,6 +93,8 @@ def __init__(
**kwargs,
) -> None:
super().__init__(**kwargs)
+ if isinstance(selected_fields, str):
+ selected_fields = [field.strip() for field in
selected_fields.split(",") if field.strip()]
Review Comment:
Was treating an empty normalized string as “all fields” intentional? Would
it be safer to raise ValueError when a provided string contains no valid fields
and add a test for that case? Did you test this case as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
