Kunal8954 commented on PR #72608: URL: https://github.com/apache/airflow/pull/72608#issuecomment-5808087705
@vincbeck — I've pushed updates addressing the backward-compatibility concern you raised, could you take another look? The change is fully additive: - `knowledge_base_configuration` is appended after all existing `__init__` parameters, so `create_knowledge_base_kwargs`, `embedding_model_arn`, `role_arn`, and `storage_config` keep their original positions and meaning; existing Dags construct the operator exactly as before. - When `knowledge_base_configuration` is not provided, `execute()` builds the same `VECTOR` config from `embedding_model_arn` and sends `storageConfiguration` as before, with `create_knowledge_base_kwargs` passthrough unchanged. New behaviour is confined to the `MANAGED` path (no `storageConfiguration`, no vector-index retry loop). - Added `test_existing_self_managed_behavior_preserved` asserting an existing self-managed Dag issues the byte-identical `CreateKnowledgeBase` call; all `BedrockCreateKnowledgeBaseOperator` unit tests pass. If it looks good, please merge the PR. Thanks! --- Drafted-by: big-pickle (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
