o-nikolas commented on code in PR #72608: URL: https://github.com/apache/airflow/pull/72608#discussion_r4129367283
########## providers/amazon/docs/operators/bedrock.rst: ########## @@ -189,6 +189,20 @@ https://docs.aws.amazon.com/bedrock/latest/userguide/knowledge-base-supported.ht :start-after: [START howto_operator_bedrock_create_knowledge_base] :end-before: [END howto_operator_bedrock_create_knowledge_base] +Managed knowledge bases can be created without configuring a vector store: + +.. code-block:: python + + BedrockCreateKnowledgeBaseOperator( + task_id="create_managed_knowledge_base", + name="my_managed_knowledge_base", + role_arn="arn:aws:iam::123456789012:role/BedrockExecutionRole", + knowledge_base_configuration={ + "type": "MANAGED", + "managedKnowledgeBaseConfiguration": {"embeddingModeType": "MANAGED"}, Review Comment: `embeddingModeType` Is a typo right? should Mode**l** not Mode? ########## providers/amazon/docs/operators/bedrock.rst: ########## @@ -189,6 +189,20 @@ https://docs.aws.amazon.com/bedrock/latest/userguide/knowledge-base-supported.ht :start-after: [START howto_operator_bedrock_create_knowledge_base] :end-before: [END howto_operator_bedrock_create_knowledge_base] +Managed knowledge bases can be created without configuring a vector store: + +.. code-block:: python + + BedrockCreateKnowledgeBaseOperator( Review Comment: Is it not worth updating the system test and using example include? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
