amoghrajesh commented on code in PR #73253:
URL: https://github.com/apache/airflow/pull/73253#discussion_r4091883318
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -3849,7 +3911,7 @@ def test_worker_outcome_retained_when_direct_api_fails(
)
with pytest.raises(httpx.ConnectError):
- watched_subprocess._handle_request(msg, structlog.get_logger(),
req_id=1)
+ watched_subprocess._send_terminal_state_msg(msg)
Review Comment:
This skips the real dispatch path for every parameterized case, not just
retry. Only the retry case needed the change. Maybe split this test it so the
non retry cases still go through `_handle_request`.
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -2086,7 +2086,7 @@ def _run_task_state_change_callbacks(
for i, callback in enumerate(getattr(task, kind)):
try:
create_executable_runner(callback,
context_get_outlet_events(context), logger=log).run(context)
- except Exception:
+ except (Exception, SystemExit):
Review Comment:
Wont this impact all callback kinds and not just on_retry_callback? What
about a on_failure_callback calling `sys.exit` to shut its process is now just
logged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
