o-nikolas commented on code in PR #73211:
URL: https://github.com/apache/airflow/pull/73211#discussion_r4095954279
##########
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py:
##########
@@ -102,22 +102,25 @@ def run(self) -> None:
continuation_token = AwsLogsHook.ContinuationToken()
while not self.is_stopped():
time.sleep(self.fetch_interval.total_seconds())
Review Comment:
You could use `self._event.wait(self.fetch_interval.total_seconds())` to
stop sooner (when the stop event is received) rather than the static wait time.
That would allow an earlier exist in some cases and save a bit of time. But not
critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
