FrankYang0529 commented on code in PR #73759: URL: https://github.com/apache/airflow/pull/73759#discussion_r4113579422
########## airflow-core/tests/unit/jobs/test_triggerer_job.py: ########## Review Comment: Thanks for the suggestion. I checked it against the two failure messages we see on CI, and the threshold would only fix one of them. - `assert '0 triggers currently running' in ''` (https://github.com/apache/airflow/actions/runs/34639425288/job/103404354117): stdout is still empty at the 30th call because the runner has not started logging yet. The watchdog has not logged anything at that point either, so a higher threshold does not help here. - stdout that only has "blocked for 300.00 seconds" lines (https://github.com/apache/airflow/actions/runs/33582219324/job/100101874765): the threshold would help here, because the watchdog lines would no longer sit ahead of the status lines. The threshold would make the logs quieter, but it would not change whether the test passes. I'd prefer to keep this PR as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
