fat-catTW commented on PR #73687: URL: https://github.com/apache/airflow/pull/73687#issuecomment-5892322341
Thanks for cleaning this up. One small concern: changing the call from `self._process_modules(...)` to `PythonDagImporter._process_modules(...)` means a subclass override would be bypassed. The same applies to calling `PythonDagImporter.get_relative_path(...)` inside `_process_modules`. Would it be better to keep `_process_modules` as an instance method with the unused args removed, and keep calling `self.get_relative_path(...)`? That preserves the current extension behavior while still getting the signature cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
