yuqian90 commented on a change in pull request #7143: [AIRFLOW-6527] Make
send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r365798474
##########
File path: airflow/executors/celery_executor.py
##########
@@ -41,6 +41,8 @@
CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
+SEND_TASK_TIMEOUT = conf.getint('celery', 'SEND_TASK_TIMEOUT')
Review comment:
@mik-laj okay I see your point. I updated to all lower case.
However, I do see a lot of places where conf entries are queried like this:
e.g.
```
airflow/bin/cli.py
'worker_timeout': Arg(
("-t", "--worker_timeout"),
default=conf.get('webserver', 'WEB_SERVER_WORKER_TIMEOUT'),
type=int,
help="The timeout for waiting on webserver workers"),
airflow/utils/log/file_task_handler.py
url = os.path.join(
"http://{ti.hostname}:{worker_log_server_port}/log";,
log_relative_path
).format(
ti=ti,
worker_log_server_port=conf.get('celery',
'WORKER_LOG_SERVER_PORT')
)
```
So something strange is going on. I did not spend much time looking into
this thought since that's not what I originally intended to investigate. One
possibility is this old change was not applied globally correctly. That's just
my speculation: https://github.com/apache/airflow/pull/5668/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
