kaxil commented on a change in pull request #7143: [AIRFLOW-6527] Make 
send_task_to_executor timeout configurable
URL: https://github.com/apache/airflow/pull/7143#discussion_r370939852
 
 

 ##########
 File path: airflow/executors/celery_executor.py
 ##########
 @@ -41,6 +41,8 @@
 
 CELERY_SEND_ERR_MSG_HEADER = 'Error sending Celery task'
 
+OPERATION_TIMEOUT = conf.getint('celery', 'operation_timeout')
 
 Review comment:
   Can we add a test for this? Let's say a user change this setting to 
`conf.get('celery', 'operation_timeout')` that test should fail.
   
   Also let's add a fallback value.
   
   ```
   OPERATION_TIMEOUT = conf.getint('celery', 'operation_timeout', fallback=2)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to