vincbeck commented on code in PR #74022:
URL: https://github.com/apache/airflow/pull/74022#discussion_r4166644191
##########
airflow-core/src/airflow/dag_processing/collection.py:
##########
@@ -291,7 +301,10 @@ def _serialize_dag_capturing_errors(
DagCode.update_source_code(
dag.dag_id, dag.fileloc, dag_source_code=dag_source_code,
session=session
)
- if "FabAuthManager" in conf.get("core", "auth_manager"):
+
+ auth_manager_cls = conf.getimport(section="core", key="auth_manager")
+ fab_auth_manager_cls = _get_fab_auth_manager_class()
+ if fab_auth_manager_cls and auth_manager_cls and
issubclass(auth_manager_cls, fab_auth_manager_cls):
Review Comment:
I would move `_sync_dag_perms` to Fab auth manager class and then do `if
getattr(get_auth_manager(), "sync_dag_perms")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
