potiuk commented on PR #70000: URL: https://github.com/apache/airflow/pull/70000#issuecomment-5977535230
Thanks for this, and for extending it to the async hook after the earlier review — a single rule shared by both hooks is exactly the right goal. We've now converged on a split approach for this: #72165 handles the sync `HttpHook`, and #72398 handles `HttpAsyncHook` with an aiohttp client middleware. The middleware runs on every redirect hop with a fresh header set, so it removes the connection-Extra headers from exactly the hop that leaves the origin while leaving aiohttp's own redirect handling (method/body rewriting, `Authorization`/`Cookie` stripping, `max_redirects`) untouched — which a manual redirect walker has to re-implement. The plan is to land those two together with one shared origin rule for both hooks. Since that covers the same ground as this PR, I'd suggest closing this one as superseded. If you'd like to stay involved, reviews on #72165 and #72398 — especially on the shared origin rule and the sync `rebuild_auth` path you already worked through here — would be very welcome. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
