divyanshus2404 commented on PR #71711: URL: https://github.com/apache/airflow/pull/71711#issuecomment-5977474417
Thanks — you were right, 7233363 wasn't needed. Reverted in 6f2239c3, so `_QUOTED_VALUE_LIMIT_RE` is back to `(?=\s)` and the scanner matches f66e620b again. Both shapes are now pinned: - `--password='Pa'$$w0rd'` is in `test_masks_passwords`. - `"password='x'," * 20_000` is in the `test_masks_passwords_stays_fast_on_repeated_keywords` parametrization. Both new cases fail on 7233363. The `'Pa'$$w0rd'` one leaks `$$w0rd'`, and the repeated-quote one takes 7.1 s against the 5 s limit. On the new head: - Your two payloads and last round's two all mask the same as `main`. - 200k random inputs, including doubled quotes and `$`, differ from `main` in 0 cases. - `"password='x'," * n` takes 1.0 / 2.0 / 4.1 ms at n = 10k / 20k / 40k. - Spark provider suite: 284 passed, 2 skipped. --- Drafted-by: Claude Code (Opus 5.5); reviewed by @divyanshus2404 before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
