potiuk commented on PR #68792: URL: https://github.com/apache/airflow/pull/68792#issuecomment-5982327239
One more thing while this waits for the code-owner look: #73454 added a third tracking set, `releasing_triggers`, after this PR was written, and the new recovery path doesn't clear it. `check_for_unhandled_triggers` (`triggerer_job_runner.py:811-816`) removes the unhandled ids from `running_triggers` and `cancelling_triggers`, but not from `releasing_triggers`. A trigger that was being released to another triggerer (it is added there from `running_triggers` at :1055) when its coroutine vanished stays in `releasing_triggers`, and since that set is part of `known_trigger_ids` (:1021-1027), it is never re-created if it is later assigned back to this triggerer — the same stuck-in-`deferred` outcome this PR fixes. Could you add `self.releasing_triggers -= unhandled` next to the other two, and extend the recovery test so one of the unhandled ids is also in `releasing_triggers` and assert it gets re-created? --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
