goyaladitay11 commented on PR #74225:
URL: https://github.com/apache/airflow/pull/74225#issuecomment-5998848154
Thanks for the clear feedback @zozo123!
I have addressed all three points:
1. Rebased onto #74191:Rebased this branch on top of `pull/74191/head` and
dropped our local copy of `UnityTableIdentity` in `assets/databricks.py`. The
sensor now directly imports and uses `UnityTableIdentity` from #74191.
2. Precise Outlet Event Semantics:
- Updated the asset outlet `extra` payload to include `observed_version`,
`version`, `table_identity` (`host`, `catalog`, `schema`, `table`),
`operation`, and `timestamp`.
- Updated the documentation to explicitly emphasize that the task-success
asset event means *"a newer Delta version was observed"*, that intermediate
commits may be coalesced, and that authors needing a pinned read must
explicitly specify `VERSION AS OF <observed_version>` in their queries.
3.Labeled Scope as Phase 1: Added explicit Phase 1 labeling across the docs,
commit, and PR title/description to make clear that this covers the
scheduled-task sensor + deferrable trigger, leaving the continuous external
asset producer path for Phase 2.
All 46 unit tests for sensor, trigger, and assets are passing. Ready for
your re-review whenever you have a chance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]