goyaladitay11 commented on PR #74225:
URL: https://github.com/apache/airflow/pull/74225#issuecomment-6013954496

   Thanks @zozo123! All four points have been addressed, verified locally (all 
1,043 unit tests passing), and pushed:
   
   1.Workspace check (P1): Added the COPY INTO workspace host guard 
`(self.hook.host or "").lower() != self.unity_table.host` in `execute()` and 
`poke()` before SQL queries run or defer. Added unit tests verifying rejection 
on host mismatch and case-insensitive host matching.
   2. Deferral config (P2):Serialized `session_configuration`, `http_headers`, 
`client_parameters`, `hook_params`, and `query_tags` into 
`DatabricksDeltaTableVersionTrigger` and forwarded them when constructing 
`DatabricksSqlHook` in `_get_hook()`. Added tests verifying config 
serialization and hook instantiation.
   3. Case folding (P2):Table parts are now lowercased first in 
`_resolve_table_name()` to handle mixed-case inputs like 
`Main.Default.Customers`. Added unit tests for mixed-case 1-part, 2-part, and 
3-part table names.
   4. Pinned read docs (P2):Updated the documentation example to use 
`ti.xcom_pull(task_ids="sensor", key="delta_table_version")["version"]` and 
updated the XCom key note.
   5. Rebase: Rebased onto the latest `main` (cleanly dropping out the #74191 
commits now that it has landed) with all tests passing and Ruff formatting 
clean.
   
   Ready for your re-review!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to