jason810496 commented on PR #71189:
URL: https://github.com/apache/airflow/pull/71189#issuecomment-6007775818
Good catch on the ADR, thanks for the approval.
ADR-0002 renamed the method and kept the task id, which is what the
diagnostic tells users to do, so the example now demonstrates the rule rather
than tripping it:
```java
@Builder.Task(id = "notify")
// "notify" is Object.notify, so the method takes another name and keeps the
task id.
public void alert(Client client) { ... }
```
That covers lines 67-68, the `Flow.of(loaded, audit()).then(alert())`
wiring, and the generated `default TaskRef<Void> alert() { return
Flow.node("notify"); }`. Lines 132, 135, 200 and 202 need no change: those are
the interface surface, where `notify` is a local variable and the id is passed
as a string, so no view method is generated.
Fixed in ff8ec8f1a91.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
