jason810496 commented on code in PR #71189:
URL: https://github.com/apache/airflow/pull/71189#discussion_r4190787083
##########
java-sdk/adr/0002-native-dag-interface.md:
##########
@@ -65,7 +65,8 @@ public class EtlPipeline { // extends nothing of ours; your
own base class stays
public void audit(Client client) { /* side effect only, no data in or out */
}
@Builder.Task(id = "notify")
- public void notify(Client client) { /* side effect only, no data in or out
*/ }
+ // "notify" is Object.notify, so the method takes another name and keeps the
task id.
+ public void alert(Client client) { /* side effect only, no data in or out */
}
Review Comment:
Good catch at the ADR, I fixed in ff8ec8f1a91.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
