uranusjr commented on code in PR #74096:
URL: https://github.com/apache/airflow/pull/74096#discussion_r4214848493
##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/Server.kt:
##########
@@ -83,10 +91,13 @@ class ApiError(
* The process exits when the coordinator closes the connection (normally after
* one task-instance execution).
*/
-class Server(
- private val comm: InetSocketAddress,
- private val logs: InetSocketAddress,
+class Server private constructor(
+ private val comm: InetSocketAddress?,
+ private val logs: InetSocketAddress?,
+ private val describeSources: File?,
) {
Review Comment:
Instead of making this class do two different modes depending on
nullability, I’d just create a separate class. We can use polymorphism to
abstract away the interface. This removes many awkward additional checks needed
in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
