uranusjr commented on code in PR #74096:
URL: https://github.com/apache/airflow/pull/74096#discussion_r4214874715
##########
java-sdk/plugin/src/main/kotlin/org/apache/airflow/sdk/plugin/AirflowSdkPlugin.kt:
##########
@@ -93,12 +98,20 @@ abstract class AirflowBundleExtension {
* identify which version of the Supervisor Schema it should use to communicate
* with the built JAR.
*
+ * When `mainClass` is set, the bundle JAR also carries the source file of each
+ * Dag declared in Java and of the entrypoint, so Airflow can show a Dag's
source.
+ * They are collected by the `packDagSources` task, which runs `mainClass`
once in
+ * a describe mode, and are listed in `META-INF/airflow/sources.json`, named
by the
+ * `Airflow-Java-SDK-Sources` manifest attribute. If that run fails, a warning
is
+ * logged and only the entrypoint's source is packed.
+ *
* If `fatJar` is explicitly set to `false`, the `bundle` task builds a bare
JAR
* containing only the Dag bundle, and collect all dependency JARs into the
target
* directory instead. In this mode, `Airflow-Supervisor-Schema-Version` lives
in
* the `airflow-sdk` JAR instead. The bundle JAR still contains `Main-Class`.
*
*/
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
