Lee-W opened a new pull request, #74451:
URL: https://github.com/apache/airflow/pull/74451
## Why
`apache-airflow-providers-common-ai` is heading to 1.0. After that, changing
a public hook's behaviour needs a deprecation cycle. This PR fixes the silent
failures and signature inconsistencies in the hooks now, before that constraint
applies.
## What
- `PydanticAIHook.test_connection` now names the provider and the ignored
connection fields when the provider class rejects the connection's credentials
and the hook retries with environment-variable auth. This also covers
connections in `fallback_conn_ids` (reported as `<conn_id>: <provider>
(ignored: <fields>)`). Before, it returned a plain "Model resolved
successfully." in that case. `docs/provider_fallback.rst` is updated to match.
- `MCPHook` validates the stdio `args` extra (must be a string or a list of
strings) and the `timeout` extra (must be a non-negative finite number; `0` and
`null` still mean no init timeout). Invalid values raise `ValueError` naming
the connection. `docs/connections/mcp.rst` is updated.
- `MCPHook.get_conn` raises `AirflowOptionalProviderFeatureException`
instead of a bare `ImportError` when the `mcp` dependency is missing. Importing
the `LLMRetryPolicy` module on Airflow < 3.3 now raises the same exception.
- `LlamaIndexHook.test_connection` now reads the LLM's `.metadata`, so a
model name that LlamaIndex's OpenAI class rejects (for example an Ollama or
vLLM model) is reported as a failure. Before, it passed and failed only on the
first `.chat()` call. It still does not call the LLM, so a revoked key or
unreachable host still passes (docstring updated).
- **Breaking:** `LangChainHook` and `LlamaIndexHookd_model` as keyword-only
arguments. The two hooks had these two parameters in opposite positional order,
so positional calls were easy to get wrong. Callers passing them positionally
must switch to keywords.
- The `vertexai` connection field is labelled "Deprecated and ignored" in
`provider.yaml` and `get_provider_info.py`. Behaviour is
unchanged, since the field was already ignored.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
<!--
Generated-by: [Claude] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
