Lee-W commented on code in PR #74451:
URL: https://github.com/apache/airflow/pull/74451#discussion_r4227774231
##########
providers/common/ai/src/airflow/providers/common/ai/hooks/pydantic_ai.py:
##########
@@ -412,6 +415,7 @@ def _provider_factory(pname: str) -> Any:
pname,
list(_kwargs),
)
+ self._env_auth_fallbacks.append(f"{pname} (ignored: {',
'.join(_kwargs)})")
Review Comment:
Done in this PR.
When a provider class rejects the connection's credentials, `get_conn()`
raises a `ValueError` naming the connection, the provider and the ignored
fields, and never rebuilds from env vars. `test_connection` thus reports it as
a failure.
Since nothing records env-var fallbacks any more, I removed
`_env_auth_fallbacks` and updated the `provider_fallback.rst` sentence and the
Vertex comment that described the old behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
