FrankYang0529 opened a new pull request, #74525:
URL: https://github.com/apache/airflow/pull/74525
In #73898, `SandboxToolset.__init__` creates a `threading.Lock`, and a lock
cannot be deep-copied. As a result, `copy.deepcopy()` on a `SandboxToolset`, or
on an operator that holds a `SandboxToolset`, raises `TypeError: cannot pickle
'_thread.lock' object`. This didn't happend in 0.10.0.
This PR moves the lock to module level, so every `SandboxToolset` shares one
lock. The Modal backend already keeps its `_CLIENT_BUILD_LOCK` at module level.
The shared lock is not held during a backend call, so one toolset doesn't wait
for another toolset's sandbox.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes - Claude Code
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
