henry3260 commented on code in PR #74548:
URL: https://github.com/apache/airflow/pull/74548#discussion_r4242279240
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py:
##########
@@ -5450,12 +5450,20 @@ def
test_clear_by_task_group_id_handles_group_larger_than_page_size(
pytest.param(True, ["a", 0], [("a", 0), ("b", -1), ("root", -1)],
id="mapped"),
],
)
+ @pytest.mark.parametrize("with_loop", [False, True], ids=["without-loop",
"with-unrelated-loop"])
def test_clear_with_upstream_and_downstream_excludes_unrelated_tasks(
Review Comment:
The narrowing looks right to me, but the name no longer fits the
`upstream=True`
case that seed is inside the loop, and it now deliberately excludes the
other mapped occurrence. Worth splitting that case into its own test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
