Rishavbhattarai commented on PR #74618:
URL: https://github.com/apache/airflow/pull/74618#issuecomment-6139549457

   Thanks for the review.
   
   - Added regression tests for `_amask_connection_secrets` and 
`handle_get_connection`. I checked that all three tests (sync, async, handler) 
fail without the fix.
   - On `quote_plus`: Airflow itself only encodes the password with `quote(..., 
safe="")` (`Connection.get_uri` in both core and the SDK), so a space becomes 
`%20`, never `+`. Parsing uses `unquote`, not `unquote_plus`, so a literal `+` 
in a URI is already the decoded password and is masked as-is. I didn't find a 
path that emits the `quote_plus` form.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to